Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] E2E Intermittent app loading - deleteme #1

Closed
wants to merge 3 commits into from

Conversation

evertonlperes
Copy link
Owner

@evertonlperes evertonlperes commented Oct 21, 2021

Changes

  1. Replaced the ipcRenderer.SendSync('settings-read') to ipcRenderer.invoke('settings-read'). --> Attempt to reduce the racing condition in order to collect the correct settings object.

Possible root cause

Possible root cause related to the error: Cannot read property 'type' of null

  • The method that collect the version/telemetry could be facing an racing condition running along with the test runner. The intermittence had reduced from 20% to 5% replacing the ipcRenderer to invoke instead SendSync.

Images/Logs

Local intermittent issue:
Screen Shot 2021-10-21 at 1 55 20 PM
Screen Shot 2021-10-21 at 2 00 07 PM
Screen Shot 2021-10-21 at 2 03 33 PM

Tests

With ipcRenderer.invoke --> Object loaded properly
Screen Shot 2021-10-22 at 4 07 39 PM

With ipcRendere.SendSync --> Object null - promise "pending"
Screen Shot 2021-10-22 at 4 44 17 PM

GitActions
https://github.com/evertonlperes/rancher-desktop/actions/runs/1374095737

Signed-off-by: evertonlperes <evertonluperes@gmail.com>
…iving null during the e2e tests

Signed-off-by: evertonlperes <evertonluperes@gmail.com>
Signed-off-by: evertonlperes <evertonluperes@gmail.com>
@evertonlperes evertonlperes marked this pull request as ready for review October 22, 2021 23:22
@evertonlperes evertonlperes changed the title [Fix] E2E Intermittent app loading [Fix] E2E Intermittent app loading - deleteme Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant