Refactor cache handler #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warlof
force-pushed
the
refactor-cache-handler
branch
10 times, most recently
from
b46641f to
2d58dca
Compare
warlof
force-pushed
the
refactor-cache-handler
branch
4 times, most recently
from
ba1347d to
f49e4d7
Compare
warlof
commented
Apr 10, 2023
|
I didn't test it, but it looks good. |
warlof
force-pushed
the
refactor-cache-handler
branch
from
401cce6 to
8f3af0e
Compare
- allow scp claim to be either a raw string or an array - force token renewal on expiration
warlof
force-pushed
the
refactor-cache-handler
branch
from
f27c929 to
5591c17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initial purpose of this pull request is to improve readability of cachable request handling.
I've extracted the overall cache check and update in a dedicated method.
by the meanwhile, I've updated ci according to code-climate updates and depreciate their test-reporter package
since we allow php 8.1, I've also added it to test coverage.
last but not least, I switch CI workflow from Travis to GitHub Actions.