Refactoring and Upgrading to .net 5.0 #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AhsanRazaUK
approved these changes
Nov 25, 2021
AhsanRazaUK
approved these changes
Nov 25, 2021
|
Hello sir, can I contribute this API with you? And if everything is OK ...
Merge them with master branch?
…On Thu, Nov 25, 2021, 10:56 AM Ahsan Raza ***@***.***> wrote:
***@***.**** approved this pull request.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#11 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANV3QGCACFKMYBSZHPKTWGTUNX25LANCNFSM5IXBHT4A>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
Yes, still in progress |
AhsanRazaUK
approved these changes
Nov 26, 2021
mahmmoudkinawy
changed the title
|
Hi @mahmmoudkinawy, Everything looks good, I will merge this pull request. Thank you for your contribution. Thank you @AhsanRazaUK for reviewing it too. I will update the Readme with the changes list later. |
|
@all-contributors please add @mahmmoudkinawy for code |
|
I've put up a pull request to add @mahmmoudkinawy! 🎉 |
|
@all-contributors please add @AhsanRazaUK for review |
|
I've put up a pull request to add @AhsanRazaUK! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there Can I Contribute on this project I'm gonna Upgrade it to .net 6.0 and Refactor Some Issues, I made a very little Refactoring, Just take a look please.