Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor BaseResponse to use generic resource type #3

Merged
merged 1 commit into from
Aug 11, 2019
Merged

Refactor BaseResponse to use generic resource type #3

merged 1 commit into from
Aug 11, 2019

Conversation

mattbarry
Copy link
Contributor

I enjoyed your article on freecodecamp.org and thought I might suggest this tweak to BaseResponse to make writing service response types a bit quicker and easier.

evgomes
evgomes approved these changes Aug 11, 2019
View reviewed changes
Copy link
Owner

@evgomes evgomes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changing, it's cleaner to use generics to handle responses this way. I'll merge this, thank you!

@evgomes evgomes merged commit ac7464e into evgomes:master Aug 11, 2019
@evgomes
Copy link
Owner

evgomes commented Nov 26, 2021

@all-contributors please add @mattbarry for code

@allcontributors allcontributors bot mentioned this pull request Nov 26, 2021
Merged
@allcontributors
Copy link
Contributor

@evgomes

I've put up a pull request to add @mattbarry! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evgomes evgomes evgomes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattbarry @evgomes