Sprint-2 login-page #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgueniazet
approved these changes
Aug 14, 2023
| mr: 2, | ||
| display: { xs: 'none', md: 'flex' }, | ||
| fontFamily: 'monospace', | ||
| fontWeight: 700, |
There was a problem hiding this comment.
All styles should be placed in the scss file. Check also other places.
LikeKugi
approved these changes
Aug 15, 2023
| <Grid item lg={7} sm={5} sx={{ | ||
| backgroundImage: `url(${LoginImage})`, | ||
| backgroundRepeat: 'no-repeat', | ||
| backgroundSize: 'cover', |
There was a problem hiding this comment.
better to do backgroundSize to contain and backgroundPosition to top.
It'll be more attractive on small screen devices
Comment on lines
+91
to
+95
| {pages.map((page) => ( | ||
| <MenuItem key={page} onClick={handleCloseNavMenu}> | ||
| <Typography textAlign="center">{page}</Typography> | ||
| </MenuItem> | ||
| ))} |
There was a problem hiding this comment.
TODO: create a new NavBar component with navigation links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sprint [sprint #2]
Task
Trello task link
Trello task link
Summary
Changelog
Screenshot