Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add numpy support to all_equal and other built-ins #689

Closed
evhub opened this issue Dec 2, 2022 · 2 comments
Closed

Add numpy support to all_equal and other built-ins #689

evhub opened this issue Dec 2, 2022 · 2 comments
Labels
feature partially resolved
Milestone
v2.2.0

Comments

@evhub
Copy link
Owner

evhub commented Dec 2, 2022 •
edited
Loading

all_equal should determine whether all elements of the array are the same. flatten, if given an array, should flatten the top axis.
@evhub evhub added this to the v2.1.2 milestone Dec 2, 2022
evhub added a commit that referenced this issue Dec 2, 2022
@evhub
Add numpy support to all_equal
3cc98f9 
Resolves   #689.
@evhub evhub closed this as completed Dec 2, 2022
@evhub evhub removed the resolved label Dec 2, 2022
@evhub evhub changed the title Add numpy support to all_equal Add numpy support to all_equal and flatten Dec 2, 2022
@evhub evhub reopened this Dec 2, 2022
@evhub evhub added the resolved label Dec 2, 2022
evhub added a commit that referenced this issue Dec 2, 2022
@evhub
Add numpy support to flatten
b608dfc 
Resolves   #689.
@evhub evhub closed this as completed Dec 2, 2022
@evhub
Copy link
Owner Author

evhub commented Dec 8, 2022

Actually, I think some of the numpy support here is bad, since you want to be able to iterate over numpy arrays in various ways without having to construct an entirely new numpy array every time.

@evhub evhub reopened this Dec 8, 2022
@evhub evhub changed the title Add numpy support to all_equal and flatten Add numpy support to all_equal Dec 8, 2022
@evhub evhub changed the title Add numpy support to all_equal Add numpy support to all_equal and other built-ins Dec 8, 2022
@evhub
Copy link
Owner Author

evhub commented Dec 8, 2022

We're going to go with numpy support for cartesian_product and all_equal, but not for flatten and cycle.

evhub added a commit that referenced this issue Dec 9, 2022
@evhub
Remove some numpy support
373f621 
Resolves   #689.
@evhub evhub closed this as completed Dec 9, 2022
@evhub evhub mentioned this issue Dec 28, 2022
Merged
evhub added a commit that referenced this issue Dec 30, 2022
@evhub
Add numpy support to all_equal
0af8a6b 
Resolves   #689.
evhub added a commit that referenced this issue Dec 30, 2022
@evhub
Add numpy support to flatten
dfc3a78 
Resolves   #689.
evhub added a commit that referenced this issue Dec 30, 2022
@evhub
Remove some numpy support
1a3fe8d 
Resolves   #689.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature partially resolved
Projects
None yet
Milestone
v2.2.0
Development

No branches or pull requests
1 participant
@evhub