Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fmap of None should be None #692

Closed
evhub opened this issue Dec 6, 2022 · 1 comment
Closed

fmap of None should be None #692

evhub opened this issue Dec 6, 2022 · 1 comment
Labels
modification won't fix

Comments

@evhub
Copy link
Owner

evhub commented Dec 6, 2022

Effectively treats Optionals as Maybes.
@evhub evhub added this to the v2.1.2 milestone Dec 6, 2022
evhub added a commit that referenced this issue Dec 6, 2022
@evhub
Improve builtins
0bacc51 
Resolves   #692, #693.
@evhub evhub added the resolved label Dec 6, 2022
@evhub evhub closed this as completed Dec 6, 2022
@evhub evhub removed this from the v2.2.0 milestone Dec 27, 2022
@evhub evhub added won't fix and removed resolved labels Dec 27, 2022
@evhub
Copy link
Owner Author

evhub commented Dec 27, 2022 •
edited
Loading

Actually, I think this doesn't make sense, since if it were treating the object as a Maybe, it shouldn't then also map over it. Instead, what we really need is None-aware function composition pipes.

evhub added a commit that referenced this issue Dec 27, 2022
@evhub
Undo fmap of None is None
2d2cdb3 
Closes   #692.
@evhub evhub mentioned this issue Dec 28, 2022
Merged
evhub added a commit that referenced this issue Dec 30, 2022
@evhub
Improve builtins
990bf78 
Resolves   #692, #693.
evhub added a commit that referenced this issue Dec 30, 2022
@evhub
Undo fmap of None is None
2f76fde 
Closes   #692.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
modification won't fix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@evhub