Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings fragment got layout for navGraph preview #731

Merged
merged 1 commit into from
May 17, 2021
Merged

Settings fragment got layout for navGraph preview #731

merged 1 commit into from
May 17, 2021

Conversation

DAT4
Copy link

@DAT4 DAT4 commented May 17, 2021

No description provided.

Copy link
Collaborator

@robinlinden robinlinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!
I'm curious, how did you even notice this was wrong? :D

@robinlinden robinlinden merged commit 84a690d into evilcorpltd:master May 17, 2021
@DAT4
Copy link
Author

DAT4 commented May 17, 2021

I just looked at the NavGraph and saw that the illustration of the fragment was missing. So I added the line. I guess its not that important, but anyways, now it looks better :-)

Have you considered switching to Jetpack Compose at some point?

@robinlinden
Copy link
Collaborator

Oh yeah, for sure. :D Switching to Jetpack Compose is on my backlog, but at first the plan is to make a separate app for the compose GUI until it reaches feature parity, and then switch to that for the main app. :P Jetpack Compose requires API 21, and aTox currently targets 19, so it would be nice to not break that compatibility if possible.

I'll probably focus more on Jetpack Compose once I start looking at iOS support since there are example projects (https://github.com/cl3m/multiplatform-compose) running it as a multiplatform thing. It would also be nice to have decent support for Jetpack Compose in stable Android Studio.

...another fantastic thing about Jetpack Compose is that getting it to work with Bazel is relatively easy. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants