App strings reworked #751
App strings reworked #751
Conversation
atox/src/main/res/values/strings.xml
Outdated
| @@ -122,20 +122,20 @@ | |||
| <string name="pref_heading_address">Address</string> | |||
| <string name="pref_heading_port">Port</string> | |||
| <string name="pref_heading_proxy">Proxy</string> | |||
| <string name="warn_proxy_broken">Bad proxy configured. Fix or disable before using app.</string> | |||
| <string name="warn_proxy_broken">Set up your proxy correctly (or turn it off) before using the app.</string> | |||
There was a problem hiding this comment.
Can you remove the full stop now that this is a single sentence?
There was a problem hiding this comment.
Reluctantly, yes.
There was a problem hiding this comment.
If you want, we can talk about how the text is set up in the app, but that might be better suited to IRC or Tox than GitHub comments? :P Right now, the only text that has any full stops at the end are the ones that are multiple sentences.
atox/src/main/res/values/strings.xml
Outdated
| <string name="pref_nospam">Nospam</string> | ||
| <string name="pref_nospam_description">Changing your nospam means that your Tox ID changes, and that your current Tox ID can no longer be used to send you friend requests</string> | ||
| <string name="pref_nospam">NoSpam</string> | ||
| <string name="pref_nospam_description">Changing your NoSpam alters your Tox ID, meaning friend requests must be sent to the updated one.</string> |
There was a problem hiding this comment.
Please drop the full stop here too. :P
|
Oh, I see you made the changes in the GitHub webgui. If you're fine with it, I can make the changes locally and push to your branch? |
|
@robinlinden Works now? Unless you want me to squash? |
|
I squashed it for you, no worries. I don't think the GitHub webgui supports it! Will merge once the PR checks have gone through. :) I appreciate the text rework! I'm mainly a programmer, so both the text and the UI/UX are a bit work-in-progress. All help with this stuff is greatly appreciated! |
No description provided.