Add mysql2 support #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prog-supdex
force-pushed
the
ci_mysql
branch
8 times, most recently
from
94eda5f
to
6096ad7
Compare
palkan
requested changes
Oct 27, 2023
|
|
||
| def initialize(klass, current_adapter_name) | ||
| @klass = klass | ||
| @current_adapter_name = current_adapter_name |
There was a problem hiding this comment.
We don't this to be a part of the adapter state; we only use it in the apply? method, so let's pass current adapter as an argument to #apply? instead.
There was a problem hiding this comment.
thanks
got it!
done!
| @klass = klass | ||
| @current_adapter_name = current_adapter_name |
palkan
approved these changes
Oct 27, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Added mysql2 support
Is there anything you'd like reviewers to focus on?
Added a new Mysql Adapter
Mysql doesn't support
ON CONFLICT(but hasON DUPLICATE KEY UPDATE) and doesn't haveRETURNING IDSo, I used
ActiveRecord::Base.connection.update(sql)for getting amount of updated rowsAlso, Mysql doesn't understand
EXCLUDED, so we need to use some methodwrap_column_name, which will be defined in every adapter. Because, Mysql understandsVALUES(here_column_names), but Postgresql understandsEXCLUDED.here_column_nameChecklist