Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Improve correctness of load_test.go #525

Merged
merged 1 commit into from
Jul 19, 2023
Merged

test: Improve correctness of load_test.go #525

merged 1 commit into from
Jul 19, 2023

Conversation

hyperupcall
Copy link
Contributor

@hyperupcall hyperupcall commented Jul 19, 2023

⚡ Summary

While working on #521, I noticed that there were slight inconsistencies with filenames and cleanup logic in this test file. This PR fixes those subtle inconsistencies that could pose issue down the line.

☑️ Checklist

  • Check locally
  • Add tests

Copy link
Member

@mrexox mrexox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contributions! I appreciate it a lot! ❤️

@mrexox mrexox merged commit ef136c4 into evilmartians:master Jul 19, 2023
10 checks passed
@hyperupcall hyperupcall deleted the hyperupcall-load-test branch July 19, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants