Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: delay git and uname commands in hook scripts until needed #737

Merged
merged 1 commit into from
May 31, 2024

Conversation

scop
Copy link
Contributor

@scop scop commented May 30, 2024

Closes # (issue)

⚡ Summary

Avoid running git and uname commands in scripts until their output is actually needed.

I suggest reviewing without showing whitespace changes due to changes in indentation.

☑️ Checklist

  • Check locally
  • Add tests
  • Add documentation

@mrexox
Copy link
Member

mrexox commented May 31, 2024

Thank you! This makes sense

@mrexox mrexox merged commit e953133 into evilmartians:master May 31, 2024
19 checks passed
@scop scop deleted the perf/hook-extra-commands branch June 2, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants