Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

link Images require a title tag #71

Closed
parmleyhunt opened this issue Jan 23, 2013 · 3 comments
Closed

link Images require a title tag #71

parmleyhunt opened this issue Jan 23, 2013 · 3 comments

Comments

@parmleyhunt
Copy link

[![alt](src "title")](link)

should also be able to only be

[![alt](src)](link)
@ashb ashb mentioned this issue Jan 23, 2013
Closed
@parmleyhunt
Copy link
Author

There are too many white-space courtesies, one of them is not being optionalized when the tag does not appear and that is what's causing it to fail. However when i try to escape one of the existing it also fails, or it doesn't allow a tag. I also tried putting in a second check for without a tag, and that still failed. Currently if you have a trailing space, but no tag it will still work.

@parmleyhunt parmleyhunt mentioned this issue Jan 23, 2013
Closed
@evgenyneu
Copy link

I noticed this bug as well.

ashb added a commit that referenced this issue Jul 26, 2013
@ashb
Add test for image without title inside link (#71)
e1813a2
@ashb
Copy link
Collaborator

ashb commented Jul 26, 2013

Fixed by another change in ecf34ff, test added in e1813a2

@ashb ashb closed this as completed Jul 26, 2013
MattKunze pushed a commit to WebDevBootcamp/markdown-js that referenced this issue Aug 4, 2013
Merge remote-tracking branch 'evilstreak/master' into upstream
8f4a6c0 
* evilstreak/master:
  Start changes file for next release
  v0.5.0
  Add test for image without title inside link (evilstreak#71)
  Update changelog since 0.4
  Style change - move function just used in table processing into Maruku.block.table
  Fix broken escaping introduected in 404344f
  added reference to new tests
  added some tests for tables
  added tolerance for up to three spaces for headers and first horizontal rule as per markdown extra
  corrected some omitted characters needing escape in _split_on_unescaped
  resolved issue with escaped pipes
  implemented tables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ashb @evgenyneu @parmleyhunt