feat(dist): Add WithdrawDelegationWithoutSend function to avoid hitting the wallet #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+216
to
+220
| func (k Keeper) WithdrawDelegationRewardsWithoutSending(ctx sdk.Context, val stakingtypes.ValidatorI, del stakingtypes.DelegationI) (sdk.Coins, error) { | ||
| // check existence of delegator starting info | ||
| if !k.HasDelegatorStartingInfo(ctx, del.GetValidatorAddr(), del.GetDelegatorAddr()) { | ||
| return nil, types.ErrEmptyDelegationDistInfo | ||
| } |
There was a problem hiding this comment.
would be good to refactor the shared code bits with the withdrawDelegationRewards method
Comment on lines
+259
to
+268
| if finalRewards.IsZero() { | ||
| baseDenom, _ := sdk.GetBaseDenom() | ||
| if baseDenom == "" { | ||
| baseDenom = sdk.DefaultBondDenom | ||
| } | ||
|
|
||
| // Note, we do not call the NewCoins constructor as we do not want the zero | ||
| // coin removed. | ||
| finalRewards = sdk.Coins{sdk.NewCoin(baseDenom, math.ZeroInt())} | ||
| } |
There was a problem hiding this comment.
also would be good to add tests for this 👍
fedekunze
reviewed
Nov 13, 2023
| k.DeleteDelegatorStartingInfo(ctx, del.GetValidatorAddr(), del.GetDelegatorAddr()) | ||
|
|
||
| if finalRewards.IsZero() { | ||
| baseDenom, _ := sdk.GetBaseDenom() |
There was a problem hiding this comment.
this could be an issue since it's hardcoded
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change