Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Problem: eth_newPendingTransactionFilter don't return correct tx hash #1011

Closed
yihuang opened this issue Mar 22, 2022 · 0 comments · Fixed by #1012
Closed

Problem: eth_newPendingTransactionFilter don't return correct tx hash #1011

yihuang opened this issue Mar 22, 2022 · 0 comments · Fixed by #1012

Comments

@yihuang
Copy link
Contributor

yihuang commented Mar 22, 2022

System info: ethermint main

Steps to reproduce:

should return eth tx hash rather than tm hash.

Expected behavior: [What you expected to happen]

Actual behavior: [What actually happened]

Additional info: [Include gist of relevant config, logs, etc.]
yihuang added a commit to yihuang/ethermint that referenced this issue Mar 22, 2022
@yihuang
Problem: eth_newPendingTransactionFilter don't return correct tx hash
b8cad02 
Closes: evmos#1011
Solution:
- use eth tx hash rather than tendermint one
@yihuang yihuang mentioned this issue Mar 22, 2022
Merged
11 tasks
fedekunze added a commit that referenced this issue Mar 24, 2022
@yihuang @fedekunze
fix: eth_newPendingTransactionFilter doesn't return ethereum tx hash (
70d5294 
#1012)

* Problem: eth_newPendingTransactionFilter don't return correct tx hash

Closes: #1011
Solution:
- use eth tx hash rather than tendermint one

* changelog

* remove copied TODO comment and ignore err result of Notify

* add e2e test

* fix ws client in e2e test

* fix test

* Apply suggestions from code review

* Apply suggestions from code review

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
yihuang added a commit to yihuang/ethermint that referenced this issue Mar 24, 2022
@yihuang @fedekunze
fix: eth_newPendingTransactionFilter doesn't return ethereum tx hash (
1e063e1 
evmos#1012)

* Problem: eth_newPendingTransactionFilter don't return correct tx hash

Closes: evmos#1011
Solution:
- use eth tx hash rather than tendermint one

* changelog

* remove copied TODO comment and ignore err result of Notify

* add e2e test

* fix ws client in e2e test

* fix test

* Apply suggestions from code review

* Apply suggestions from code review

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
yihuang added a commit to yihuang/ethermint that referenced this issue Mar 24, 2022
@yihuang @fedekunze
fix: eth_newPendingTransactionFilter doesn't return ethereum tx hash (
f4db90b 
evmos#1012)

* Problem: eth_newPendingTransactionFilter don't return correct tx hash

Closes: evmos#1011
Solution:
- use eth tx hash rather than tendermint one

* changelog

* remove copied TODO comment and ignore err result of Notify

* add e2e test

* fix ws client in e2e test

* fix test

* Apply suggestions from code review

* Apply suggestions from code review

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Problem: eth_newPendingTransactionFilter don't return correct tx hash yihuang/ethermint
1 participant
@yihuang