Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

fix!: fix json-rpc failures for pruned nodes #1126

Merged
merged 6 commits into from
Jun 22, 2022
Merged

Conversation

yihuang
Copy link
Contributor

@yihuang yihuang commented Jun 14, 2022

Closes: #1123
Solution:

  • try to parse base fee from events if grpc query failed
  • use a nil base fee if both grpc query and event parsing failed
  • use zero address if query validator address failed
  • optimize some json-rpc apis by the way.

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Closes: evmos#1123
Solution:
- try to parse base fee from events if grpc query failed
- use a `nil` base fee if failed to parse base fee from events
- use zero address if query validator address failed
- optimize some json-rpc apis by the way.
Copy link
Contributor

@crypto-facs crypto-facs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything LGTM besides my comment! 🚀

rpc/backend/evm_backend.go Show resolved Hide resolved
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@fedekunze fedekunze merged commit 2ce1685 into evmos:main Jun 22, 2022
@yihuang yihuang deleted the pruned-rpc branch June 22, 2022 14:35
devon-chain pushed a commit to PundiAI/ethermint that referenced this pull request Jun 28, 2022
* fix json-rpc failures for pruned nodes

Closes: evmos#1123
Solution:
- try to parse base fee from events if grpc query failed
- use a `nil` base fee if failed to parse base fee from events
- use zero address if query validator address failed
- optimize some json-rpc apis by the way.

* changelog

* fix lint

* use GetTendermintBlockResultByNumber

* refactor

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
yihuang added a commit to yihuang/ethermint that referenced this pull request Jun 30, 2022
Closes: evmos#1123
Solution:
- try to parse base fee from events if grpc query failed
- use a `nil` base fee if failed to parse base fee from events
- use zero address if query validator address failed
- optimize some json-rpc apis by the way.

* changelog

* fix lint

* use GetTendermintBlockResultByNumber

* refactor

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve json-rpc in pruned nodes
3 participants