-
Notifications
You must be signed in to change notification settings - Fork 566
Fix grpc query failure on legacy blocks #1354
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1354 +/- ##
==========================================
+ Coverage 54.77% 54.78% +0.01%
==========================================
Files 107 108 +1
Lines 9994 10015 +21
==========================================
+ Hits 5474 5487 +13
- Misses 4249 4255 +6
- Partials 271 273 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @yihuang. Can you add unit and integration tests for this change?
sure, I'm still investigating another case with |
`BaseFee` and `EthCall`. Solution: - since grpc query handlers are used for all versions of the blocks, it need to be compatible with legacy formats. debug fix basefee fetch Revert "debug" This reverts commit 50ebaf697fc06b0d6e26abd8de8f89717e8a219d. update gomod2nix Update CHANGELOG.md debug fix panic Revert "debug" This reverts commit e08af04b0776bd390c42706cc9ec978e00bcb3bb.
seems hard to do a unit test for this, I'll port the integration test in cronos to here. |
integration test added, and we also need to update cosmos-sdk to recent 0.46.x to make it pass. |
@yihuang some unit tests are failing |
interesting, it doesn't reproduce locally, can you try rerun? |
|
It don't reproduce when run locally, and didn't seem to be related to this PR, maybe has sth to do with SDK update. |
Description
Mainly
BaseFee
andEthCall
.Solution:
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)