-
Notifications
You must be signed in to change notification settings - Fork 566
Conversation
In the context of ethermint, probabely we need to have a mode that start grpc and json-rpc together, but could leave that to another issue. |
maybe just query-only flag, we can pass like |
or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
think it might be a good idea to use a bool
flag instead of a string
for the query-only mode, seems to simplify the code and use?
5953248
to
06b7d82
Compare
which need tm client on start
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure the JSON-RPC only flag will work properly without tendermint. The --grpc-only
looks good to me
Closes: #1359
Description
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)