Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

[issue-#1018] EVM Module keeper - Improve code coverage #1396

Merged
merged 13 commits into from
Oct 21, 2022

Conversation

GAtom22
Copy link
Contributor

@GAtom22 GAtom22 commented Oct 20, 2022

Closes: #1018

Description

Currently, code coverage for the EVM module keeper is about 72%.

The objective of this PR is to bump it to >90%


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@GAtom22 GAtom22 added the Type: Tests issues and PR related to tests label Oct 20, 2022
@github-actions github-actions bot removed the Type: Tests issues and PR related to tests label Oct 20, 2022
@GAtom22 GAtom22 requested a review from facs95 October 20, 2022 21:57
@GAtom22 GAtom22 marked this pull request as ready for review October 20, 2022 22:01
@GAtom22 GAtom22 requested a review from a team as a code owner October 20, 2022 22:01
@GAtom22 GAtom22 requested review from Vvaradinov and removed request for a team October 20, 2022 22:01
@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Merging #1396 (1a0d732) into main (157f188) will increase coverage by 1.60%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1396      +/-   ##
==========================================
+ Coverage   56.05%   57.66%   +1.60%     
==========================================
  Files         108      108              
  Lines       10074    10074              
==========================================
+ Hits         5647     5809     +162     
+ Misses       4143     4019     -124     
+ Partials      284      246      -38     
Impacted Files Coverage Δ
x/evm/keeper/msg_server.go 93.61% <0.00%> (+3.19%) ⬆️
x/evm/keeper/state_transition.go 82.55% <0.00%> (+5.52%) ⬆️
x/evm/keeper/statedb.go 81.37% <0.00%> (+8.96%) ⬆️
x/evm/keeper/keeper.go 89.47% <0.00%> (+11.11%) ⬆️
x/evm/keeper/utils.go 82.50% <0.00%> (+15.00%) ⬆️
x/evm/keeper/grpc_query.go 89.20% <0.00%> (+20.14%) ⬆️
x/evm/keeper/migrations.go 100.00% <0.00%> (+50.00%) ⬆️
x/evm/keeper/abci.go 100.00% <0.00%> (+80.00%) ⬆️

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests are great! left some minor comments. Thanks @GAtom22!

x/evm/keeper/abci_test.go Outdated Show resolved Hide resolved
x/evm/keeper/grpc_query_test.go Outdated Show resolved Hide resolved
x/evm/keeper/grpc_query_test.go Outdated Show resolved Hide resolved
x/evm/keeper/grpc_query_test.go Outdated Show resolved Hide resolved
x/evm/keeper/grpc_query_test.go Outdated Show resolved Hide resolved
x/evm/keeper/grpc_query_test.go Outdated Show resolved Hide resolved
@fedekunze fedekunze merged commit f04b289 into main Oct 21, 2022
@fedekunze fedekunze deleted the GAtom22/Improve-code-cov-evm-keeper branch October 21, 2022 16:59
@danburck danburck mentioned this pull request Nov 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve code coverage for x/evm/keeper
2 participants