Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

feat: add limit for eth_call return value #1682

Closed
wants to merge 5 commits into from

Conversation

mmsqe
Copy link
Contributor

@mmsqe mmsqe commented Feb 24, 2023

Closes: #XXX

Description

Add return limit for eth_call to alleviate memory usage, time result with 100 concurrent single requests

command time --verbose ethermintd start --home exploit0/ethermint_9000-1/node0

No limit:
Maximum resident set size (kbytes): 1800972
Default limit:
Maximum resident set size (kbytes): 530044


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Merging #1682 (d3d12c8) into main (f594627) will decrease coverage by 0.03%.
The diff coverage is 33.33%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1682      +/-   ##
==========================================
- Coverage   68.15%   68.13%   -0.03%     
==========================================
  Files         112      112              
  Lines       10175    10181       +6     
==========================================
+ Hits         6935     6937       +2     
- Misses       2832     2835       +3     
- Partials      408      409       +1     
Impacted Files Coverage Δ
rpc/backend/call_tx.go 60.58% <25.00%> (-0.47%) ⬇️
server/config/config.go 23.16% <50.00%> (+0.30%) ⬆️

@mmsqe mmsqe marked this pull request as ready for review February 24, 2023 05:53
@mmsqe mmsqe requested a review from a team as a code owner February 24, 2023 05:53
@mmsqe mmsqe requested review from Vvaradinov and GAtom22 and removed request for a team February 24, 2023 05:53
@github-actions
Copy link

github-actions bot commented May 9, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days-before-close if no further activity occurs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants