This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
feat: Cosmos SDK v47 integration #1782
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update to sdk v0.47.2 newer btcutil
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -196,7 +196,7 @@ | |||
| args.chainID, _ = cmd.Flags().GetString(flags.FlagChainID) | |||
| args.minGasPrices, _ = cmd.Flags().GetString(sdkserver.FlagMinGasPrices) | |||
| args.numValidators, _ = cmd.Flags().GetInt(flagNumValidators) | |||
| args.algo, _ = cmd.Flags().GetString(flags.FlagKeyAlgorithm) | |||
| args.algo, _ = cmd.Flags().GetString(flags.FlagKeyType) | |||
Check warning
Code scanning / gosec
Returned error is not propagated up the stack.
| @@ -161,7 +161,7 @@ | |||
| args.nodeDaemonHome, _ = cmd.Flags().GetString(flagNodeDaemonHome) | |||
| args.startingIPAddress, _ = cmd.Flags().GetString(flagStartingIPAddress) | |||
| args.numValidators, _ = cmd.Flags().GetInt(flagNumValidators) | |||
| args.algo, _ = cmd.Flags().GetString(flags.FlagKeyAlgorithm) | |||
| args.algo, _ = cmd.Flags().GetString(flags.FlagKeyType) | |||
Check warning
Code scanning / gosec
Returned error is not propagated up the stack.
| @@ -75,7 +76,7 @@ | |||
| interactive, _ := cmd.Flags().GetBool(flagInteractive) | |||
| noBackup, _ := cmd.Flags().GetBool(flagNoBackup) | |||
| useLedger, _ := cmd.Flags().GetBool(flags.FlagUseLedger) | |||
| algoStr, _ := cmd.Flags().GetString(flags.FlagKeyAlgorithm) | |||
| algoStr, _ := cmd.Flags().GetString(flags.FlagKeyType) | |||
Check warning
Code scanning / gosec
Returned error is not propagated up the stack.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1782 +/- ##
==========================================
- Coverage 68.89% 68.88% -0.02%
==========================================
Files 117 117
Lines 10681 10824 +143
==========================================
+ Hits 7359 7456 +97
- Misses 2900 2936 +36
- Partials 422 432 +10
|
fix evm
mmsqe
requested review from
facs95 and
MalteHerrmann
and removed request for
a team
mmsqe
commented
Jun 8, 2023
| @@ -274,7 +274,7 @@ func (suite *AnteTestSuite) TestRejectDeliverMsgsInAuthz() { | |||
| }, | |||
| ), | |||
| }, | |||
| expectedCode: sdkerrors.ErrUnauthorized.ABCICode(), | |||
| expectedCode: sdkerrors.ErrUnpackAny.ABCICode(), | |||
There was a problem hiding this comment.
err code change, for more info
11 tasks
This reverts commit 2c58a53.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days-before-close if no further activity occurs. |
mmsqe
added a commit
to crypto-org-chain/ethermint
that referenced
this pull request
Aug 1, 2023
* integrate with sdk V47 & ibc-go V7 * update proto-gen and proto files * fix e2e tests * tmp * working tmp * fix rebase conflict * fix merge conflict * fix test * recover makefile changes * fix lint * fix protoc-gen-tool script * update tendermint dependency * update btcsuite/btcutil path * update gomod2nix * fix Makefile,regen proto files and remove third_party proto * update gomod2nix * fix lint * update nix * replace cometbft tm-db update to sdk v0.47.2 newer btcutil * algo -> key-type * set mempool * set chainId * update protobuf * fix import * fix test * debug test * update nix * fix btcsuite * make proto-gen follow by UPGRADING.md * fix sync issue with latest blk for more info, see https://github.com/cosmos/cosmos-sdk/blob/main/UPGRADING.md#replaces * disable depguard * gogo/protobuf -> cosmos/gogoproto * no pass chain_id after setup ethermintd config chain-id * fix lint * fix err msg due to empty version check fix for more info, see https://github.com/cosmos/cosmos-sdk/pull/13355/files * add the crisis store in store upgrades * fix lint * add consensus upgrade * migrate consensus parameters * fix lint * allow flag overwrite chainId * fix ConsensusParams fix evm * fix lint * add paramKeyTable * add change log * err code change due to nested msg check * fix lint * cleanup mod * add nil check for consParams.Block * Revert "fix ConsensusParams" This reverts commit b739244. * sdk to v0.47.3 and ibc-go to v7.1.0 * point to logger fix * get consParams from keeper if not in ctx * point back cometbft * fix broadcast mode * fix lint * update default params for test * cleanup deps * fix ibc client route in gov router * fix broadcast mode * fix ibctm for more info, see https://github.com/cosmos/ibc-go/blob/v7.2.0/docs/migrations/v6-to-v7.md#chains * point to sdk cp fix * Update rpc/backend/utils.go Co-authored-by: yihuang <huang@crypto.com> Signed-off-by: mmsqe <mavis@crypto.com> * Update rpc/types/utils.go Co-authored-by: yihuang <huang@crypto.com> Signed-off-by: mmsqe <mavis@crypto.com> * fix build * revert get params by consensusparamkeeper * keep validator err msg * Revert "keep validator err msg" This reverts commit 20253ce. * test with more retries * add expect_cb * fix hooks * rm RandomizedParams ProposalContents * prune expire state --------- Signed-off-by: mmsqe <mavis@crypto.com> Co-authored-by: jay tseng <jay.tseng@crypto.com> Co-authored-by: yihuang <huang@crypto.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopen #1687
Description
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)