Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

rpc: implement internal debug_ API namespace functions #313

Merged
merged 35 commits into from
Jul 20, 2021

Conversation

hanchon
Copy link
Contributor

@hanchon hanchon commented Jul 16, 2021

Ref: #71 (This PR is 1/3 of the issue)

Description

This PR is the first one to start implementing the _debug namespace.
The _debug namespace has 3 parts:

  • Internal debug: Profiling functions. This PR.
  • Logger configuration: Allows the user the change the logger settings, for example the log level. This needs to be implemented in another PR.
  • Trace calls: This calls return blockchain information (Blocks and Transactions). This needs to be implemented to support etherscan.

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work. (This was internally discussed with @fedekunze)
  • Code follows the module structure standards.
  • [] Wrote unit and integration tests
    (Note: we based the code on the go-etherum codebase, it test some functionality from the runtime lib, but not the API endpoint. For example: https://github.com/ethereum/go-ethereum/blob/master/metrics/runtime_test.go, we can add these tests if they are needed)
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Minor stylistic comments only

ethereum/rpc/namespaces/debug/internal.go Outdated Show resolved Hide resolved
ethereum/rpc/namespaces/debug/internal.go Outdated Show resolved Hide resolved
ethereum/rpc/namespaces/debug/internal.go Outdated Show resolved Hide resolved
ethereum/rpc/namespaces/debug/internal.go Outdated Show resolved Hide resolved
ethereum/rpc/namespaces/debug/internal.go Outdated Show resolved Hide resolved
ethereum/rpc/namespaces/debug/internal.go Outdated Show resolved Hide resolved
@fedekunze fedekunze changed the title rpc:debug_api added internal _debug functions rpc: implement internal debug_ API namespace functions Jul 17, 2021
ramacarlucho and others added 5 commits July 19, 2021 12:40
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@fedekunze fedekunze enabled auto-merge (squash) July 20, 2021 12:40
@fedekunze fedekunze merged commit 282eb13 into evmos:main Jul 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants