Miner namespace #377

hanchon · 2021-07-27T13:39:48Z

Closes: #173

Description

This PR implements the miner namespaces endpoints.

For contributor use:

Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Code follows the module structure standards.
Wrote unit and integration tests
Updated relevant documentation (docs/) or specification (x/<module>/spec/)
Added relevant godoc comments.
Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
Re-reviewed Files changed in the Github PR explorer

For admin use:

Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
Reviewers assigned
Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

…iner_namespace

ethereum/rpc/namespaces/miner/api.go

ethereum/rpc/namespaces/miner/unsupported.go

Miner corrections

ethereum/rpc/namespaces/eth/api.go

ethereum/rpc/namespaces/miner/api.go

Renames and log changes Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

fedekunze

Looks good, can you add the changelog and update the JSON-RPC docs too 🙏

ethereum/rpc/namespaces/eth/api.go

ethereum/rpc/namespaces/miner/api.go

hanchon · 2021-08-03T17:09:56Z

Looks good, can you add the changelog and update the JSON-RPC docs too 🙏

I'm working on it

return false in case of error Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

hanchon · 2021-08-03T17:50:44Z

Looks good, can you add the changelog and update the JSON-RPC docs too 🙏

I'm working on it

Docs and changelog already updated

fedekunze

LGTM. Minor comments

CHANGELOG.md

ethereum/rpc/namespaces/miner/api.go

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

fedekunze

LGTM, utACK

ramacarlucho and others added 12 commits July 26, 2021 11:35

miner namespace

7ef52ce

SetGasPrice call

dce20db

Added note plus fixed error logging

60808e0

Refactor to use the keyring in the miner namespace

609677e

Merge branch 'tharsis:main' into miner_namespace

e22252b

Changed keyring function return

f9d4a01

Added more detailed logs to unsupported functions

bfc58d8

Merge branch 'miner_namespace' of github.com:hanchon/ethermint into m…

b479e04

…iner_namespace

Reverted changes on ethapi and just using a refrence to it on miner

d7b5f87

Creating a transaction

61742f7

fix condition

292ccfc

Error string not capitalized

0e527ce

fedekunze reviewed Jul 28, 2021

View reviewed changes

ethereum/rpc/namespaces/miner/api.go Outdated Show resolved Hide resolved

ethereum/rpc/namespaces/miner/api.go Outdated Show resolved Hide resolved

ethereum/rpc/namespaces/miner/api.go Outdated Show resolved Hide resolved

fedekunze reviewed Jul 28, 2021

View reviewed changes

ramacarlucho and others added 11 commits July 28, 2021 11:42

suggested changes to setEtherbase

0af193d

change log level

37c1950

minor changes

6efe47c

minor changes

b10cc83

Merge branch 'tharsis:main' into miner_corrections

5fc883e

Merge branch 'tharsis:main' into miner_namespace

b6ffa96

Sending tx to test the endpoint

78e0a46

get tx nonce

66c9aa4

Using aphoton const and changing the logger to debug

4807d4d

Merge pull request #1 from hanchon/miner_corrections

235a3a6

Miner corrections

Using default RPC gas limit constant

6179c5b

fedekunze reviewed Jul 28, 2021

View reviewed changes

ramacarlucho and others added 4 commits July 29, 2021 10:07

Apply suggestions from code review

5e025d6

Renames and log changes Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

pair programming session

e89bc48

get gas

f243ad8

Set gas prices note added

ef576c5

hanchon and others added 2 commits August 2, 2021 17:00

Setting fess and max gas

adb4cf9

delete unnecessary log

0faf64e

fedekunze reviewed Aug 3, 2021

View reviewed changes

ethereum/rpc/namespaces/eth/api.go Outdated Show resolved Hide resolved

ethereum/rpc/namespaces/miner/api.go Show resolved Hide resolved

ethereum/rpc/namespaces/miner/api.go Show resolved Hide resolved

ethereum/rpc/namespaces/miner/api.go Show resolved Hide resolved

ramacarlucho and others added 3 commits August 3, 2021 14:11

Apply suggestions from code review

7757254

return false in case of error Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

Suggested changes applied

1a09f3f

Updated changelog and json_rpc docs

2987a8b

hanchon changed the title ~~WIP: Miner namespace~~ Miner namespace Aug 3, 2021

hanchon marked this pull request as ready for review August 3, 2021 17:50

hanchon requested a review from khoslaventures as a code owner August 3, 2021 17:50

fedekunze reviewed Aug 3, 2021

View reviewed changes

ramacarlucho and others added 7 commits August 3, 2021 15:41

Update CHANGELOG.md

6acf94c

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

Update ethereum/rpc/namespaces/miner/api.go

11c56f9

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

Update ethereum/rpc/namespaces/miner/api.go

106d709

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

Update ethereum/rpc/namespaces/miner/api.go

bbd1567

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

Update ethereum/rpc/namespaces/miner/api.go

a5e5fd3

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

Using the same coin denom as the gas price for the fee

41b51f6

Merge branch 'tharsis:main' into miner_namespace

430bfe2

fedekunze approved these changes Aug 4, 2021

View reviewed changes

fedekunze enabled auto-merge (squash) August 4, 2021 09:12

fedekunze merged commit 396db9f into evmos:main Aug 4, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Miner namespace #377

Miner namespace #377

hanchon commented Jul 27, 2021

fedekunze left a comment

hanchon commented Aug 3, 2021

hanchon commented Aug 3, 2021

fedekunze left a comment

fedekunze left a comment

Miner namespace #377

Miner namespace #377

Conversation

hanchon commented Jul 27, 2021

Description

fedekunze left a comment

Choose a reason for hiding this comment

hanchon commented Aug 3, 2021

hanchon commented Aug 3, 2021

fedekunze left a comment

Choose a reason for hiding this comment

fedekunze left a comment

Choose a reason for hiding this comment