-
Notifications
You must be signed in to change notification settings - Fork 562
Conversation
Codecov Report
@@ Coverage Diff @@
## main #461 +/- ##
==========================================
+ Coverage 49.18% 49.22% +0.03%
==========================================
Files 57 57
Lines 5363 5408 +45
==========================================
+ Hits 2638 2662 +24
- Misses 2608 2629 +21
Partials 117 117
|
e64825a
to
b5a9b6b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment. I would like to propose a cleaner implementation that doesn't add a new store key and relies on the store Iterator
to retrieve the logs
Visit https://dashboard.github.orijtech.com?back=0&pr=461&remote=true&repo=JayT106%2Fethermint to see benchmark details. |
c67845b
to
893de26
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK. Thanks @JayT106! Can you add a Changelog entry under the improvements section 🙏
Sure, will do. Thanks for the review. |
6cccaa1
to
670586b
Compare
Description
after profiling BenchmarkEmitLogs in #436
found we can improve the emit log speed by changing the log store structure.
Therefore, we store each log separately
prefixlogkey | txHash | log.Index
, not stores by []logsThe change improves the log store by around 90x within the testcase.
In #436:
In This PR:
Updated PR:
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)