This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
Fix panic when transaction is reverted #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas-nguy
requested review from
fedekunze,
jolube and
khoslaventures
as code owners
Codecov Report
@@ Coverage Diff @@
## main #650 +/- ##
==========================================
- Coverage 56.01% 51.37% -4.64%
==========================================
Files 63 63
Lines 5502 5518 +16
==========================================
- Hits 3082 2835 -247
- Misses 2257 2515 +258
- Partials 163 168 +5
|
yihuang
reviewed
Oct 8, 2021
yihuang
reviewed
Oct 8, 2021
thomas-nguy
force-pushed
the
thomas/fix-bug-reverted
branch
from
518a446
to
ae54988
Compare
11 tasks
fedekunze
approved these changes
Oct 8, 2021
thomas-nguy
force-pushed
the
thomas/fix-bug-reverted
branch
from
ae54988
to
ecf8382
Compare
fedekunze
reviewed
Oct 8, 2021
fedekunze
added a commit
that referenced
this pull request
Oct 8, 2021
* fix panic when transaction is reverted * update changelog * Update x/evm/keeper/context_stack.go Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
fedekunze
added a commit
that referenced
this pull request
Oct 8, 2021
* ci: add bencher config (#652) Add bencher config with global +-10% threshold for improvements and regressions Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> * fix conflicts * evm: fix panic when transaction is reverted (#650) * fix panic when transaction is reverted * update changelog * Update x/evm/keeper/context_stack.go Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> * rpc: test fix (#608) * fix rpc tests with net namespace * skip personal test * skip rpc pending test * fix endpoint * fix rpc pending test * fix missing gas param in some rpc tests * fix eth_getproof when the block number is equal to pending or latest * fix rpc tests filter subscribe failed * lint * remove unused linter * fix PendingTransactionFilter and TestEth_GetFilterChanges_BlockFilter * fix eth_estimateGas * fix TestEth_EstimateGas_ContractDeployment * skip TestEth_ExportAccount_WithStorage * remove sleep in rpc test * Update changelog * add test-rpc in github action * bump golangci-lint version to v1.42.1 * release: v0.7.1 cherry-picks * changelog * ci: fix solidity tests (#278) * Fix CI * Remove verbose-log to reduce size * update timeout * rm deploy contract action * Update test-helper.js * Update workflow * Update workflow * fix gas estimate amount * Update test.yml * fix error assert issue * ignore bad test case * remove estimate gas test * Change fromBlock to 1 (TEMP, Reverse Required) * bump timeout Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> Co-authored-by: yihuang <huang@crypto.com> Co-authored-by: Federico Kunze <federico.kunze94@gmail.com> Co-authored-by: Daniel Burckhardt <daniel.m.burckhardt@gmail.com> Co-authored-by: Thomas Nguy <81727899+thomas-nguy@users.noreply.github.com> Co-authored-by: JayT106 <JayT106@users.noreply.github.com> Co-authored-by: Yijia Su <85918228+yijiasu-crypto@users.noreply.github.com> Co-authored-by: yihuang <huang@crypto.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current behavior will panic when flatten the stack of cache in case transaction is reverted because the cache context is already flattened
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)