This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
Problem: No test on the transaction receipt api #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihuang
requested review from
fedekunze,
jolube and
khoslaventures
as code owners
Codecov Report
@@ Coverage Diff @@
## main #678 +/- ##
==========================================
- Coverage 57.00% 56.83% -0.17%
==========================================
Files 63 64 +1
Lines 5566 5602 +36
==========================================
+ Hits 3173 3184 +11
- Misses 2232 2251 +19
- Partials 161 167 +6
|
fedekunze
approved these changes
Oct 16, 2021
| ) | ||
|
|
||
| // HexString is a byte array that serializes to hex | ||
| type HexString []byte |
There was a problem hiding this comment.
q: why not use the go-ethereum type?
There was a problem hiding this comment.
go-ethereum version has the ‘0x’ prefix automatically, but the solc generated json don’t have that.
yihuang
force-pushed
the
test_rpc_receipt
branch
from
e6230d4 to
41a4ce2
Compare
yihuang
commented
Oct 17, 2021
| @@ -17,6 +17,9 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| steps: | |||
| - uses: actions/checkout@v2.3.4 | |||
| - uses: actions/setup-go@v2 | |||
| with: | |||
| go-version: 1.17 | |||
There was a problem hiding this comment.
otherwise, the default go compiler in CI fails to build.
fedekunze
approved these changes
Oct 18, 2021
|
seems that |
Closes: evmos#582 - add receipt rpc test for erc20 transfer logs
yihuang
force-pushed
the
test_rpc_receipt
branch
from
139de24 to
1f72708
Compare
fixed now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #582
Description
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)