This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
Problem: missing json rpc for eth_resend #675 #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leejw51crypto
requested review from
fedekunze,
jolube and
khoslaventures
as code owners
leejw51crypto
force-pushed
the
feature/675
branch
from
3989e3f to
a04e098
Compare
fedekunze
reviewed
Oct 18, 2021
rpc/ethereum/namespaces/eth/api.go
Outdated
| if cap == 0 { | ||
| return nil | ||
| } | ||
| feeEth := new(big.Float).Quo(new(big.Float).SetInt(new(big.Int).Mul(gasPrice, new(big.Int).SetUint64(gas))), new(big.Float).SetInt(big.NewInt(params.Ether))) |
There was a problem hiding this comment.
can we split this line? it's really hard to read
|
modified |
leejw51crypto
force-pushed
the
feature/675
branch
from
d751e1c to
e2e2aef
Compare
add unit test restore Update server/start.go thanks~ Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> tidy up checkTxFee change comments
leejw51crypto
force-pushed
the
feature/675
branch
from
e2e2aef to
5df8c43
Compare
fedekunze
approved these changes
Oct 20, 2021
Codecov Report
@@ Coverage Diff @@
## main #684 +/- ##
==========================================
+ Coverage 56.83% 57.00% +0.16%
==========================================
Files 64 63 -1
Lines 5602 5566 -36
==========================================
- Hits 3184 3173 -11
+ Misses 2251 2232 -19
+ Partials 167 161 -6
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: add max tx fee check for eth_resend