This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 566
Use effectiveGasPrice in ante handler for dynamic fee tx #817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihuang
requested review from
fedekunze,
jolube and
khoslaventures
as code owners
December 9, 2021 06:38
Closes: evmos#814 Solution: - use effectiveGasPrice when check minimal-gas-prices, and deduct fee in ante handler - implement an EthMempoolFeeDecorator
thomas-nguy
reviewed
Dec 9, 2021
thomas-nguy
reviewed
Dec 9, 2021
Codecov Report
@@ Coverage Diff @@
## main #817 +/- ##
==========================================
- Coverage 57.34% 56.99% -0.36%
==========================================
Files 72 72
Lines 5981 6041 +60
==========================================
+ Hits 3430 3443 +13
- Misses 2354 2398 +44
- Partials 197 200 +3
|
yihuang
commented
Dec 9, 2021
yihuang
commented
Dec 9, 2021
yihuang
commented
Dec 9, 2021
thomas-nguy
reviewed
Dec 9, 2021
thomas-nguy
reviewed
Dec 9, 2021
thomas-nguy
reviewed
Dec 9, 2021
thomas-nguy
approved these changes
Dec 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Co-authored-by: Thomas Nguy <81727899+thomas-nguy@users.noreply.github.com>
fedekunze
approved these changes
Dec 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK, minor comments
13 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #814
Description
Solution:
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)