Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

remove redundant ante handler #819

Merged
merged 3 commits into from
Dec 15, 2021
Merged

Conversation

yihuang
Copy link
Contributor

@yihuang yihuang commented Dec 10, 2021

They are already checked in EthValidateBasicDecorator

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, can you add a changelog entry?

They are already checked in EthValidateBasicDecorator
@yihuang yihuang force-pushed the redundant-ante-handler branch from 9962456 to d722366 Compare December 15, 2021 02:14
@yihuang
Copy link
Contributor Author

yihuang commented Dec 15, 2021

ACK, can you add a changelog entry?

done

@codecov
Copy link

codecov bot commented Dec 15, 2021

Codecov Report

Merging #819 (d722366) into main (ccc6f5b) will increase coverage by 0.30%.
The diff coverage is n/a.

❗ Current head d722366 differs from pull request most recent head f827724. Consider uploading reports for the commit f827724 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #819      +/-   ##
==========================================
+ Coverage   56.76%   57.07%   +0.30%     
==========================================
  Files          72       72              
  Lines        6039     5980      -59     
==========================================
- Hits         3428     3413      -15     
+ Misses       2411     2370      -41     
+ Partials      200      197       -3     
Impacted Files Coverage Δ
app/ante/ante.go 48.10% <ø> (+9.82%) ⬆️
x/evm/types/tx_data.go 85.41% <0.00%> (ø)
x/evm/keeper/utils.go 72.85% <0.00%> (+0.79%) ⬆️
app/ante/eth.go 85.57% <0.00%> (+1.20%) ⬆️
x/evm/types/access_list_tx.go 70.94% <0.00%> (+1.86%) ⬆️
x/evm/types/dynamic_fee_tx.go 78.61% <0.00%> (+2.63%) ⬆️
x/evm/types/legacy_tx.go 95.20% <0.00%> (+2.95%) ⬆️
x/evm/types/msg.go 69.89% <0.00%> (+4.23%) ⬆️

@fedekunze fedekunze enabled auto-merge (squash) December 15, 2021 02:14
@fedekunze fedekunze merged commit 9828964 into evmos:main Dec 15, 2021
@yihuang yihuang deleted the redundant-ante-handler branch December 15, 2021 03:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants