This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihuang
requested review from
fedekunze,
jolube and
khoslaventures
as code owners
December 23, 2021 07:56
yihuang
force-pushed
the
check-base-fee
branch
2 times, most recently
from
December 23, 2021 08:08
bc26de7
to
db3d931
Compare
Codecov Report
@@ Coverage Diff @@
## main #855 +/- ##
==========================================
- Coverage 56.79% 56.63% -0.17%
==========================================
Files 72 72
Lines 6060 6060
==========================================
- Hits 3442 3432 -10
- Misses 2420 2429 +9
- Partials 198 199 +1
|
fedekunze
suggested changes
Dec 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggested changes LGTM. I'd add more test cases for the new behavior and also add a changelog entry.
fedekunze
approved these changes
Dec 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK, can you add a changelog entry?
yihuang
force-pushed
the
check-base-fee
branch
from
December 27, 2021 07:02
29a51f2
to
fabc43b
Compare
Closes: evmos#755 ``` if not london_hardfork { # reject DynamicFeeTx # no `baseFeePerGas` field in block response # baseFee = nil } else { # allow DynamicFeeTx # add `baseFeePerGas` field in block response if feemarketParams.NoBaseFee or height < feemarketParams.EnableHeight { # baseFee = 0 } else { # init baseFee to initBaseFee and adjust in later blocks } } ``` Update x/evm/keeper/keeper.go Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> add unit tests Update app/ante/utils_test.go Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> changelog
yihuang
force-pushed
the
check-base-fee
branch
from
December 27, 2021 07:24
fabc43b
to
a6c9658
Compare
done, also added unit test for |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #755
Description
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)