Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

fix: several issues with the passing receipt to hooks change #869

Merged
merged 2 commits into from
Jan 4, 2022

Conversation

yihuang
Copy link
Contributor

@yihuang yihuang commented Jan 4, 2022

Description

Closes: #868

Solution:

  • contract address in receipt should only be the newly created contract
  • fix the order of operations in state transition
  • compute contract address in ApplyTransaction on the fly

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Closes: evmos#868

Solution:
- contract address in receipt should only be the newly created contract
- fix the order of operations in state transition
- compute contract address in `ApplyTransaction` on the fly
@codecov
Copy link

codecov bot commented Jan 4, 2022

Codecov Report

Merging #869 (15c4ee3) into main (7ec5e5f) will increase coverage by 0.03%.
The diff coverage is 90.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #869      +/-   ##
==========================================
+ Coverage   57.40%   57.43%   +0.03%     
==========================================
  Files          74       74              
  Lines        6148     6153       +5     
==========================================
+ Hits         3529     3534       +5     
  Misses       2408     2408              
  Partials      211      211              
Impacted Files Coverage Δ
x/evm/keeper/state_transition.go 76.85% <90.62%> (+0.34%) ⬆️

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes LGTM. Thanks for the improvements @yihuang!

@fedekunze fedekunze merged commit 7c53e32 into evmos:main Jan 4, 2022
@yihuang yihuang deleted the fix-hooks-receipt branch January 4, 2022 11:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

several issues with the passing receipt to hooks change
2 participants