fix: lint issues #1487
Merged
fix: lint issues #1487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GAtom22
requested review from
0a1c,
facs95,
Vvaradinov,
a team and
MalteHerrmann
and removed request for
a team
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1487 +/- ##
==========================================
+ Coverage 73.08% 73.13% +0.05%
==========================================
Files 268 268
Lines 18446 18415 -31
==========================================
- Hits 13481 13468 -13
+ Misses 4365 4350 -15
+ Partials 600 597 -3
|
MalteHerrmann
requested changes
Mar 22, 2023
There was a problem hiding this comment.
Great stuff @GAtom22! I left a bunch of comments, but these are all concerned with 2 main things:
- I wouldn't use
nolint:allexcept where it's necessary, and always indicate why the linter is escaped using the comments - Personally I would prefer if we follow a clear standard in the repo. I see that it makes sense for mocked functions to still have the unused parameters in the function signature to describe the expected interface. How about we do the following:
- In case of mocking, leave the unused parameters as is and comment with
//nolint:revive // allow unused parameters to indicate expected signature - In case we're not mocking, replace unused parameters with
_ - All code, where we are sure that it can be removed without problems (e.g. testsuite setup), remove unused parameters from signature
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com>
… GAtom22/linting
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| recover, _ := cmd.Flags().GetBool(genutilcli.FlagRecover) | ||
| if recover { | ||
|
|
||
| recoverKey, _ := cmd.Flags().GetBool(genutilcli.FlagRecover) |
Check warning
Code scanning / gosec
Returned error is not propagated up the stack.
| @@ -196,8 +196,8 @@ | |||
| // Get bip39 mnemonic | |||
| var mnemonic, bip39Passphrase string | |||
|
|
|||
| recover, _ := cmd.Flags().GetBool(flagRecover) | |||
| if recover { | |||
| recoverKey, _ := cmd.Flags().GetBool(flagRecover) | |||
Check warning
Code scanning / gosec
Returned error is not propagated up the stack.
MalteHerrmann
approved these changes
Mar 22, 2023
0a1c
pushed a commit
that referenced
this pull request
Mar 25, 2023
Merged
facs95
pushed a commit
that referenced
this pull request
Mar 25, 2023
* fix: lint issues (#1487) * Bump Cosmos SDK dependency to v0.46.10-ledger.1 * Update changelog and upgrade handler versions * Add changelog entry --------- Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When updated the gh actions workflows to use go 1.20 on this PR, the golangci-lint was upgraded to v1.52.0. This upgrade brought up many lint issues that weren't considered before. This PR addresses those lint issues
Closes #XXX