bug(vesting): clawback only unvested coins #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns is not allowed and allow clawback to only transfer unvested tokens
Codecov Report
@@ Coverage Diff @@
## main #317 +/- ##
==========================================
+ Coverage 65.04% 65.53% +0.49%
==========================================
Files 93 93
Lines 6191 6137 -54
==========================================
- Hits 4027 4022 -5
+ Misses 2007 1963 -44
+ Partials 157 152 -5
|
danburck
requested review from
fedekunze,
khoslaventures and
jolube
as code owners
danburck
changed the title
danburck
changed the title
12 tasks
fedekunze
reviewed
Mar 1, 2022
fedekunze
approved these changes
Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds integration tests for clawback, remove unnecessary staking logic during clawback (as staking unvested tokens is not allowed ) and refactors the clawback to only allow clawback of unvested tokens.