Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scripts and README.md file to deal with Issue #1 #2

Merged
merged 6 commits into from
Apr 6, 2024

Conversation

sabifo4
Copy link
Contributor

@sabifo4 sabifo4 commented Apr 1, 2024

Hi Sishuo,

As suggested, here you have a pull request. Below, you can find a list of the steps I followed:

  1. Fork your repository.
  2. Include the changes that we made to run bs_inBV in your ruby scripts.
  3. Update the main README.md file to make it much easier to understand the following:
  • Installation procedure (i.e., gems, third-party-tools, changes to code required).
  • Usage + Example.
  • PAML usage when running MCMCtree with the approximate likelihood calculation.

Once you revise the proposed changes, if you think everything makes sense, you can merge the repos!

All the best,
Sandy

@evolbeginner
Copy link
Owner

Dear Sandra,

Thanks so much! I will test it soon. meanwhile, i have created a v1.0 release for the previous version.

I think the following is why i thought only "colorize" and "parallel" need to be installed for ruby gems. i will add a testing script on top of your PR. In ruby 3.0+ some of the following have been installed by default (but except for "bio" and "bio-nwk"); I didn't realize the diff ruby versions issue until you pointed it out (not many people use ruby in bioinfo today). any Qs suggestions and Qs pls don't hesitate to let me know. Thanks again!

image

cheers,
sishuo

@evolbeginner evolbeginner merged commit 80cea17 into evolbeginner:main Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants