Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOS: Added identification for which action was taken in case there wa… #328

Merged
merged 2 commits into from
Feb 24, 2017

Conversation

alialamine
Copy link
Contributor

Added the action_identifier key when the action has been taken

@evollu
Copy link
Owner

evollu commented Feb 24, 2017

can you provide more detail about the issue?

@alialamine
Copy link
Contributor Author

alialamine commented Feb 24, 2017

In my application, I have two buttons on the notification: View and Delete

With the current behaviour, there is no way to detect which button is pressed, so this pull request adds the actionIdentifier to be returned with the results to be able to detect which button is pressed.

Note: I'll update the pull request once I get to the office to fix the merge conflict

@evollu
Copy link
Owner

evollu commented Feb 24, 2017

can you share more about how you add these buttons?
I wonder your can solve the problem for #325

@sibelius
Copy link

I think it is worth to add this to the example

@evollu
Copy link
Owner

evollu commented Feb 24, 2017

looks good. can you use _actionIdentifier for the flag name?
@sibelius what do you think about flag naming convention?

@sibelius
Copy link

_actionIdentifier is a good name

@evollu evollu merged commit 7d867f8 into evollu:master Feb 24, 2017
@evollu
Copy link
Owner

evollu commented Feb 24, 2017

published in v6.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants