-
Notifications
You must be signed in to change notification settings - Fork 678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android actions fixes #1 #835
Conversation
String actionValue = actions[a].trim(); | ||
Intent actionIntent = new Intent(mContext, intentClass); | ||
List<String> actions = bundle.getStringArrayList("android_actions"); | ||
bundle.remove("android_actions"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's keep the bundle as is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@evollu okay, so what the way to keep android_actions
and don't come across parsing error? It happened when parsing the Intent in FIRMessagingModule.java
: it can't parse ArrayList
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm..ok
|
@evollu in this PR it was changed to
thus it shouldn't failing |
I've published the change. |
@evollu thanks |
Fixes
IntentClass
=>IntentClassName
.android_actions
as an array, for example:android_actions
is anArrayList
so the bundle can't correctly be parsed, I have addedbundle.remove("android_actions");
to avoid any parsing errors (we will not use this field further so it is unnecessary). Any workarounds for this or it's OK?