Move Kafka-related functionality to stracer-kafka module [CE2] #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a back-port of #281
This PR moves all Kafka-related functionality into a separate stracer-kafka module. Since it's a breaking change (classes are removed from the main library and it's necessary to bring in a new one), the major version is bumped to 5.0.0.
Motivation: bringing stracer into the classpath automatically means bringing some version of skafka. Sometimes it's simply unnecessary (e.g. when data classes are received via HTTP), and sometimes it can be very inconvenient, e.g. when this library and some other pull different major versions of skafkainto the classpath, but ReportSpanRecord isn't used in the application, however, sbt screams about major version eviction.
Moreover, ReportSpanRecord is additional functionality, not directly related to the data classes that comprise the core of the library.