Add typescript server #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evolutionleo
approved these changes
Feb 18, 2021
There was a problem hiding this comment.
Great! Seems like a nice addition!
I have one concern though: So, in networking.ts:4 you export type Data, which is a string-string object. Doesn't it mean that you can only send strings to the server?
If so, it would probably be better to change the value type to any
|
Yup, now that you mention it, I don't really know why I put it to string, it would be much better if it was |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
So, in a new TypescriptServer folder, I converted the server code into typescript, and merged all of the secondary files (constructors/, custom/ and static/) into a single networking file.
So, uh, tell me what you think of it I guess