Skip to content

Commit

Permalink
fix(ci): for bash on win part 1
Browse files Browse the repository at this point in the history
node orb compatibility see  CircleCI-Public/node-orb#32
  • Loading branch information
duncdrum committed Aug 18, 2021
1 parent f71d72f commit 7657494
Showing 1 changed file with 33 additions and 6 deletions.
39 changes: 33 additions & 6 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ version: 2.1
# - add notarisation signing for win/mac on circle (post-step)
# - squash circle commits
# - add context for secrets
# - contact support about windows orb fail
# see https://github.com/circleci/circleci-docs/issues/5611

orbs:
# see https://circleci.com/developer/orbs/orb/circleci/node
Expand All @@ -17,13 +17,13 @@ executors:
# auth:
# username: mydockerhub-user
# password: $DOCKERHUB_PASSWORD
windows: win/default
# windows: win/default
macos: # macos executor using xcode 11 should it be 12?
macos:
xcode: 12.5.1

jobs:
compile:
build-nix:
parameters:
os:
type: executor
Expand Down Expand Up @@ -52,11 +52,38 @@ jobs:
- run: node --version
- run: yarn --version
- run: yarn build
build-win:
parameters:
node-version:
type: string
executor:
name: win/default
shell: bash.exe
steps:
- checkout
- node/install:
node-version: << parameters.node-version >>
install-yarn: true
install-npm: false
- node/install-packages:
cache-path: ~/project/node_modules
# TODO: check if this is what we want, what we really really want
override-ci-command: yarn install --ignore-engines
pkg-manager: yarn
- run: node --version
- run: yarn --version
- run: yarn build


workflows:
compile-all:
jobs:
- compile:
- build-nix:
matrix:
parameters:
os: [linux, macos]
node-version: ["12.22.5", "14.17.5"]
- build-win:
matrix:
parameters:
os: [linux, windows, macos]
node-version: ["12.22.5", "14.17.5"]
node-version: ["12.22.5", "14.17.5"]

0 comments on commit 7657494

Please sign in to comment.