Fix created columns (#726)

The default was wrong, the `"now()"` was executed when building the
database, resulting in a default of a constant value instead of the
function `now()`

backend/alembic/versions/1961954c0320_fix_created_columns.py

@@ -0,0 +1,33 @@
+"""fix created columns
+
+Revision ID: 1961954c0320
+Revises: 19ddf67a4eeb
+Create Date: 2024-05-14 18:52:54.234776
+
+"""
+
+from alembic import op
+
+# revision identifiers, used by Alembic.
+revision: str | None = "1961954c0320"
+down_revision: str | None = "19ddf67a4eeb"
+branch_labels: str | None = None
+depends_on: str | None = None
+
+
+def upgrade() -> None:
+    op.execute("ALTER TABLE clubs ALTER COLUMN created SET DEFAULT NOW();")
+    op.execute("ALTER TABLE tournaments ALTER COLUMN created SET DEFAULT NOW();")
+    op.execute("ALTER TABLE stages ALTER COLUMN created SET DEFAULT NOW();")
+    op.execute("ALTER TABLE stage_items ALTER COLUMN created SET DEFAULT NOW();")
+    op.execute("ALTER TABLE rounds ALTER COLUMN created SET DEFAULT NOW();")
+    op.execute("ALTER TABLE matches ALTER COLUMN created SET DEFAULT NOW();")
+    op.execute("ALTER TABLE teams ALTER COLUMN created SET DEFAULT NOW();")
+    op.execute("ALTER TABLE players ALTER COLUMN created SET DEFAULT NOW();")
+    op.execute("ALTER TABLE users ALTER COLUMN created SET DEFAULT NOW();")
+    op.execute("ALTER TABLE courts ALTER COLUMN created SET DEFAULT NOW();")
+
+
+def downgrade() -> None:
+    # No rollback because it will introduce bugs.
+    pass

backend/bracket/schema.py

@@ -1,4 +1,4 @@
-from sqlalchemy import Column, ForeignKey, Integer, String, Table
+from sqlalchemy import Column, ForeignKey, Integer, String, Table, func
 from sqlalchemy.orm import declarative_base  # type: ignore[attr-defined]
 from sqlalchemy.sql.sqltypes import BigInteger, Boolean, DateTime, Enum, Float, Text
 
@@ -11,15 +11,15 @@
     metadata,
     Column("id", BigInteger, primary_key=True, index=True, autoincrement=True),
     Column("name", String, nullable=False, index=True),
-    Column("created", DateTimeTZ, nullable=False),
+    Column("created", DateTimeTZ, nullable=False, server_default=func.now()),
 )
 
 tournaments = Table(
     "tournaments",
     metadata,
     Column("id", BigInteger, primary_key=True, index=True),
     Column("name", String, nullable=False, index=True),
-    Column("created", DateTimeTZ, nullable=False, server_default="now()"),
+    Column("created", DateTimeTZ, nullable=False, server_default=func.now()),
     Column("start_time", DateTimeTZ, nullable=False),
     Column("club_id", BigInteger, ForeignKey("clubs.id"), index=True, nullable=False),
     Column("dashboard_public", Boolean, nullable=False),
@@ -36,7 +36,7 @@
     metadata,
     Column("id", BigInteger, primary_key=True, index=True),
     Column("name", String, nullable=False, index=True),
-    Column("created", DateTimeTZ, nullable=False),
+    Column("created", DateTimeTZ, nullable=False, server_default=func.now()),
     Column("tournament_id", BigInteger, ForeignKey("tournaments.id"), index=True, nullable=False),
     Column("is_active", Boolean, nullable=False, server_default="false"),
 )
@@ -46,7 +46,7 @@
     metadata,
     Column("id", BigInteger, primary_key=True, index=True),
     Column("name", Text, nullable=False),
-    Column("created", DateTimeTZ, nullable=False, server_default="now()"),
+    Column("created", DateTimeTZ, nullable=False, server_default=func.now()),
     Column("stage_id", BigInteger, ForeignKey("stages.id"), index=True, nullable=False),
     Column("team_count", Integer, nullable=False),
     Column(
@@ -84,7 +84,7 @@
     metadata,
     Column("id", BigInteger, primary_key=True, index=True),
     Column("name", Text, nullable=False),
-    Column("created", DateTimeTZ, nullable=False),
+    Column("created", DateTimeTZ, nullable=False, server_default=func.now()),
     Column("is_draft", Boolean, nullable=False),
     Column("is_active", Boolean, nullable=False, server_default="false"),
     Column("stage_item_id", BigInteger, ForeignKey("stage_items.id"), nullable=False),
@@ -95,7 +95,7 @@
     "matches",
     metadata,
     Column("id", BigInteger, primary_key=True, index=True),
-    Column("created", DateTimeTZ, nullable=False),
+    Column("created", DateTimeTZ, nullable=False, server_default=func.now()),
     Column("start_time", DateTimeTZ, nullable=True),
     Column("duration_minutes", Integer, nullable=True),
     Column("margin_minutes", Integer, nullable=True),
@@ -125,7 +125,7 @@
     metadata,
     Column("id", BigInteger, primary_key=True, index=True),
     Column("name", String, nullable=False, index=True),
-    Column("created", DateTimeTZ, nullable=False),
+    Column("created", DateTimeTZ, nullable=False, server_default=func.now()),
     Column("tournament_id", BigInteger, ForeignKey("tournaments.id"), index=True, nullable=False),
     Column("active", Boolean, nullable=False, index=True, server_default="t"),
     Column("elo_score", Float, nullable=False, server_default="0"),
@@ -141,7 +141,7 @@
     metadata,
     Column("id", BigInteger, primary_key=True, index=True),
     Column("name", String, nullable=False, index=True),
-    Column("created", DateTimeTZ, nullable=False),
+    Column("created", DateTimeTZ, nullable=False, server_default=func.now()),
     Column("tournament_id", BigInteger, ForeignKey("tournaments.id"), index=True, nullable=False),
     Column("elo_score", Float, nullable=False),
     Column("swiss_score", Float, nullable=False),
@@ -158,7 +158,7 @@
     Column("email", String, nullable=False, index=True, unique=True),
     Column("name", String, nullable=False),
     Column("password_hash", String, nullable=False),
-    Column("created", DateTimeTZ, nullable=False),
+    Column("created", DateTimeTZ, nullable=False, server_default=func.now()),
     Column(
         "account_type",
         Enum(
@@ -201,6 +201,6 @@
     metadata,
     Column("id", BigInteger, primary_key=True, index=True),
     Column("name", Text, nullable=False),
-    Column("created", DateTimeTZ, nullable=False),
+    Column("created", DateTimeTZ, nullable=False, server_default=func.now()),
     Column("tournament_id", BigInteger, ForeignKey("tournaments.id"), nullable=False, index=True),
 )