Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign teams to subsequent elimination rounds #1001

Merged
merged 7 commits into from
Nov 8, 2024

Conversation

evroon
Copy link
Owner

@evroon evroon commented Nov 8, 2024

fixes #998

Copy link

vercel bot commented Nov 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bracket ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2024 4:31pm

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 89.24731% with 10 lines in your changes missing coverage. Please review.

Project coverage is 93.04%. Comparing base (ed659ff) to head (986f83a).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
backend/bracket/logic/ranking/elimination.py 88.46% 3 Missing ⚠️
backend/bracket/routes/rankings.py 50.00% 2 Missing ⚠️
backend/bracket/sql/matches.py 50.00% 2 Missing ⚠️
backend/bracket/models/db/match.py 87.50% 1 Missing ⚠️
backend/bracket/routes/matches.py 90.00% 1 Missing ⚠️
backend/bracket/sql/stage_items.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1001   +/-   ##
=======================================
  Coverage   93.04%   93.04%           
=======================================
  Files         114      116    +2     
  Lines        4040     4099   +59     
=======================================
+ Hits         3759     3814   +55     
- Misses        281      285    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@evroon evroon merged commit 6aa2c51 into master Nov 8, 2024
11 checks passed
@evroon evroon deleted the assign-teams-to-subsequent-elimination-rounds branch November 8, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assign teams to subsequent matches in single elimination when score has been updated
1 participant