Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: added volume, network and port to docker compose #814

Merged
merged 5 commits into from
Aug 28, 2024

Conversation

djpiper28
Copy link
Contributor

Fixes issue where containers cannot to talk to each other where the default docker network is isolated.

Copy link

vercel bot commented Jul 11, 2024

@djpiper28 is attempting to deploy a commit to the evroon's projects Team on Vercel.

A member of the Team first needs to authorize it.

@djpiper28 djpiper28 changed the title Feat: added network and port to docker compose Feat: added volume, network and port to docker compose Jul 11, 2024
docs/docs/deployment/docker.md Outdated Show resolved Hide resolved
docker-compose.yml Show resolved Hide resolved
docker-compose.yml Show resolved Hide resolved
docker-compose.yml Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
@djpiper28
Copy link
Contributor Author

oh yeah I have some helm charts (Kubernetes for Bracket) should I make a PR to add them?

@djpiper28
Copy link
Contributor Author

@evroon are you able to review this when you have time please?

Copy link
Owner

@evroon evroon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docker-compose.yml looks good, I just have some comments about the docs.
Also, maybe we should add a volume in the production example as well now that we're adding it to the docker-compose.yml

NEXT_PUBLIC_API_BASE_URL: "https://bracket.mywebsite.com"
# Go to https://dashboard.hcaptcha.com/signup, create a site and put the site key here
NEXT_PUBLIC_HCAPTCHA_SITE_KEY: "xxxxx"
NODE_ENV: "production"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still want to keep the NODE_ENV: "production" right?

NEXT_PUBLIC_HCAPTCHA_SITE_KEY: "xxxxx"
NODE_ENV: "production"
NEXT_PUBLIC_API_BASE_URL: "http://your-site.com:8400"
NEXT_PUBLIC_HCAPTCHA_SITE_KEY: "10000000-ffff-ffff-ffff-000000000001" # Public test key
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to keep the instruction # Go to https://dashboard.hcaptcha.com/signup, create a site and put the site key here here, since it is more clear what the value here should be. Putting a test key here would probably result in users just copy/pasting and accidentally using the test key in production without noticing I think

Copy link
Contributor

This PR is stale because it has been open for 45 days with no activity. Remove the stale label or comment or this will be closed in 30 days.

@evroon
Copy link
Owner

evroon commented Aug 28, 2024

I'll resolve my comments in a separate PR

@evroon evroon merged commit a2f63ab into evroon:master Aug 28, 2024
2 of 3 checks passed
evroon added a commit that referenced this pull request Aug 30, 2024
Implements feedback from #814
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants