Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow changing inputs after creating stage item #962

Merged
merged 15 commits into from
Oct 26, 2024

Conversation

evroon
Copy link
Owner

@evroon evroon commented Oct 24, 2024

No description provided.

@evroon evroon self-assigned this Oct 24, 2024
Copy link

vercel bot commented Oct 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bracket ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2024 5:32pm

@evroon evroon marked this pull request as ready for review October 24, 2024 20:00
@evroon evroon force-pushed the allow-changing-inputs-after-creating-stage-item branch from 60af847 to 4200349 Compare October 24, 2024 20:05
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 91.60839% with 12 lines in your changes missing coverage. Please review.

Project coverage is 93.50%. Comparing base (ec2b02f) to head (9f52cda).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
backend/bracket/routes/stage_item_inputs.py 84.84% 5 Missing ⚠️
backend/bracket/logic/scheduling/builder.py 50.00% 4 Missing ⚠️
backend/bracket/models/db/stage_item.py 75.00% 1 Missing ⚠️
backend/bracket/sql/stage_items.py 93.33% 1 Missing ⚠️
backend/bracket/utils/errors.py 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #962      +/-   ##
==========================================
+ Coverage   93.18%   93.50%   +0.31%     
==========================================
  Files         112      113       +1     
  Lines        3890     3970      +80     
==========================================
+ Hits         3625     3712      +87     
+ Misses        265      258       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

… Allow changing inputs after creating stage item
… fixup! Allow changing inputs after creating stage item
… fixup! fixup! Allow changing inputs after creating stage item
… fixup! fixup! fixup! Allow changing inputs after creating stage item
… fixup! fixup! fixup! fixup! Allow changing inputs after creating stage item
@evroon evroon merged commit d32c360 into master Oct 26, 2024
10 checks passed
@evroon evroon deleted the allow-changing-inputs-after-creating-stage-item branch October 26, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant