wip #17
Closed
wip #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evykassirer
commented
Oct 30, 2024
evykassirer
force-pushed
the
stream-edit-typescript
branch
7 times, most recently
from
ec66712 to
04b8d8d
Compare
This will help with the typescript conversion.
…_status_handler. This had been getting undefined `sub` already, but managed to not cause errors because `properties_elements` was empty and `button_state` didn't equal `"unsaved"`, leaving areas that treated `sub` as defined not accessible. This commit fixes the type and handles the `undefined` case more directly.
evykassirer
force-pushed
the
stream-edit-typescript
branch
from
04b8d8d to
40b7770
Compare
None of these have showed up in Sentry in the last 90 days, and it will be easier to type this file if we can assume we always get a valid stream id and a valid sub for that stream id.
`sub.email_address` can be `undefined`, `$foo.text(undefined)` has no effect (it doesn't clear the text), and `text()` doesn't formally accept `undefined`, so here we only call `text()` if the new value isn't undefined.
It seems like this was working fine, thanks to some internal workings of Handlebars, but when we convert this file to typescript, it will want a string for `html_body`.
These were all manually checked to still work. `e.currentTarget` is equivalent to `this`, and all instance of `e.target` were either the same as `this` or used with a `closest` function that still got the same value.
This will help with the typescript conversion for this file.
evykassirer
force-pushed
the
stream-edit-typescript
branch
from
40b7770 to
a00e444
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.