this needs splitting for sure #20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to have the lists of rendered users so we can check if we should be showing the links. This commit fixes a bug where we showed the "view all subscribers" link even if all subscribers were visible on the screen.
evykassirer
force-pushed
the
buddy-list-fix-has-inactive-users-matching-view
branch
from
ba3c1f7 to
90132ec
Compare
evykassirer
force-pushed
the
buddy-list-fix-has-inactive-users-matching-view
branch
from
90132ec to
ada7a9e
Compare
evykassirer
commented
Nov 27, 2024
| @@ -443,20 +439,6 @@ export class BuddyList extends BuddyListConf { | |||
|
|
|||
| const {current_sub, total_human_subscribers_count, other_users_count} = this.render_data; | |||
| $(".buddy-list-subsection-header").empty(); | |||
|
|
|||
| // If we're in the mode of hiding headers, that means we're only showing the "others" | |||
There was a problem hiding this comment.
add to the commit message that this now escapes the return
evykassirer
commented
Nov 27, 2024
web/src/buddy_list.ts
Outdated
| @@ -426,7 +427,7 @@ export class BuddyList extends BuddyListConf { | |||
| } | |||
|
|
|||
| render_section_headers(): void { | |||
| const {hide_headers, all_participant_ids} = this.render_data; | |||
| const {hide_headers, all_participant_ids, total_human_subscribers_count} = this.render_data; | |||
This also fixes a bug where the code to hide the matching view container didn't run when we early-returned from `render_section_headers`. Now it always runs in `display_or_hide_sections`.
evykassirer
force-pushed
the
buddy-list-fix-has-inactive-users-matching-view
branch
from
ada7a9e to
b65bef3
Compare
evykassirer
deleted the
buddy-list-fix-has-inactive-users-matching-view
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.