Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unread.js to typescript #6

Closed
wants to merge 160 commits into from
Closed

unread.js to typescript #6

wants to merge 160 commits into from

Conversation

evykassirer
Copy link
Owner

for futzing

evykassirer
evykassirer commented Dec 13, 2023
View reviewed changes
web/src/unread.ts

return res;
return {
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

convert res in its own commit

karlstolley and others added 11 commits December 12, 2023 17:31
@karlstolley @timabbott
portico: Correct layout on deactivation pages.
9cc0ded
@amanagr @timabbott
billing: Apply common styles to billing pages.
da74b9a
@amanagr @timabbott
populate_billing_realms: Call sessions with billing_user.
e9ce69a
@laurynmm @timabbott
corporate: Show error page if mobile push data has not been uploaded.
aebafcc 
Adds a template that displays an error message when the billing
or upgrade context for a remote server or remote realm raises a
MissingDataError.
@alexmv @timabbott
register_server: POST requests take data, not params.
44e9171 
This currently _works_, but only because we are very forgiving about
how we parse requests.
@karlstolley @timabbott
portico: Update strings for RemoteRealm login flow.
180dd00
@amanagr @timabbott
remote_billing_email_confirm: Minor text changes.
0d08fe9 
* Move email early in text to reduce change of it wrapping to
  next line.

* Change 2 hours to 24 hours.
@alexmv @timabbott
remote_activity: Hide deactivated remote servers.
19575b4
@amanagr @timabbott
remote_billing_login: Show different title for deactivate login.
c263635
@amanagr @timabbott
server_deactivate: Show error message for server on active plan.
63f4fc5
@timabbott
billing_session: Push nocoverage comments down a layer.
f281199
@evykassirer evykassirer force-pushed the unread-typescript branch 2 times, most recently from b6caab2 to ec61163 Compare December 13, 2023 06:54
@sayamsamal @timabbott
compose_actions: Hide compose box when navigating to inbox/recent view.
7f26905 
Currently, given that the compose box is already open, it stays open
when the user navigates to the inbox/recent view, even when there is
no modifications to the message or recipients.

This commit adds conditions to close the compose box when navigating
to the inbox/recent view, except when we can reasonably infer that it
was the intended action.
amanagr and others added 12 commits December 12, 2023 23:27
@amanagr @timabbott
portico: Pass requested sponsorship context to plan page.
45a2f7e
@timabbott
billing: Remove some stale TODOs.
af83093
@timabbott
billing: Don't require data to add to legacy plan.
95f4b31
@sahil839 @timabbott
popover: Fix user popover and profile for bot with inaccessible users.
27d236f 
We incorrectly passed bot owner ID to get_bot_owner_user instead of
the bot object.
@sayamsamal @timabbott
gear_menu_popover: Update the rocket icon used for plan and pricing.
c61b353 
Fixes zulip#28163.
@amanagr @timabbott
stripe: Don't approve sponsorship for customers on paid plan.
0c99420 
This would avoid us accidentally approving sponsorship for customers
on paid plan.
@amanagr @timabbott
sponsorship: Show sponsored plan name for sponsored orgs.
998685f 
The `plan_name` is incorrect here since the customer will not
have an active plan for approved sponsorship.
@amanagr @timabbott
billing: Link plan name to /plans page.
039f6af
@amanagr @timabbott
stripe: Add user and org metadata to stripe payments.
081d94c
@amanagr @timabbott
remote_billing_page: Fix redirects for self hosted login.
9efb236
@amanagr @timabbott
populate_billing_realms: Don't create plan for sponsored remote realm.
35b644c
@laurynmm @timabbott
support: Include sponsorship request for remote server support view.
e8500fb 
Preparation for updating the sponsorship forms template to include
information about the latest sponsorship request if sponsorship is
pending.
andersk and others added 16 commits December 16, 2023 22:08
@andersk @timabbott
models: Extract zerver.models.alert_words.
33d140c 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
@andersk @timabbott
models: Move query_for_ids to zerver.lib.query_helpers.
c343d7c 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
@andersk @timabbott
models: Extract zerver.models.lookups.
b38f3d2 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
@amanagr @timabbott
pricing_plans: Fix scrollbars always visible.
d85462a 
Kick in min-width at the required width.
This will ensure that scrollbars are only visible if the window
is at this width.
@amanagr @timabbott
plans: Fix same page hashtag link.
6b1f718 
Fixes /plans fragment links redirecting users to different page.
@timabbott
plans: Fix community plan documentation.
1e0339c 
It appears the plans page version of this had a less clear/specific
list of example communities than was intended. Also improve the longer
version in the Help Center to give the same examples.
@amanagr @timabbott
sponsorship_request: Minor changes.
311a645 
* Show if requested org is hosted on Zulip Cloud.
* Change how user numbers are displayed.
@timabbott
zilencer: Fix community plan push notifications.
5dc1d36
@evykassirer @timabbott
message_store: Migrate message_store to typescript.
24dc2e7
@timabbott
zilencer: Fix can_push logging bug with system bot realms.
3993697 
We could be incorrectly logging the can_push value associated with the
system bot realm when only a single human realm existed on a server.
@evykassirer @timabbott
unread: Use some clearer variable names.
5c9bb51
@evykassirer @timabbott
unread: Rename KeyDict to key_to_bucket.
722494b
@evykassirer @timabbott
unread: Create key_to_bucket object in call to constructor.
6596598
@evykassirer @timabbott
unread: Use message type instead of checking stream_id.
f15a687
@evykassirer @timabbott
unread: Return objects directly, no functional change.
bfff48d
@Lalit3716 @timabbott
ts: Migrate popover_menus to typescript.
02257b8 
This commit migrates `popover_menus` module to TypeScript. Also adds
a placeholder types declaration file for `css_variables` module.
@evykassirer evykassirer force-pushed the unread-typescript branch 2 times, most recently from 43b0bbd to 34c03a9 Compare December 21, 2023 22:08
@evykassirer
FoldDict: Always use IterableIterator.
fbce7ea 
Being more specific will help in converting
the unread module to typescript.
@evykassirer evykassirer force-pushed the unread-typescript branch 3 times, most recently from 9dfabed to 2280bbb Compare December 22, 2023 00:08
@evykassirer evykassirer deleted the unread-typescript branch December 23, 2023 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.