learn: Prepare for txtar support by levy #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve test export tests to print more readable error message on failure and add a TODO to composition so we won't forget to to add exercise round-robin when we create unit tests and quizzes in the future. These are more preparatory non-functional changes.
Improve error messages to not include Filenames twice. Filenames should be added as close as possible to were the error happens not in a higher-level course or unit model when the error originates from the answer.
Make markdown questions testdata more meaningful and ensure the description matches the question and answer: If the question contains source code the question should be "What does this program output", rather than the previous copy-paste error: "Which program generates the following output".
Add Filename() method to model interface. This allows us to use model.Filename() to create the HTML output files rather than relying on the original `mdFiles` slice from which we created the models. In a follow-up commit we break 1-1 relationship between .md and .html files when we create sub-question from txtar files. For these types of questions we require that the QuestionModel provides its (target) filename.
Remove embedMD type and use renderer directly. embedMD only had a renderer and an ID for debug purposes and testing, let's simplify things.
Factor out QuestionModel.correctAnswerIndices method so that we can re-use it in a follow-up commit for printing answers for .txtar links.
30 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QuestionModel.correctAnswerIndicesmethod for later reuse bytxtar.
QuestionModel based on txtar sub-questions that don't have an underlying
filename.
And further testdata and error message improvements.