Do Linting Suggestions #33

ewanwm · 2024-07-27T22:23:05Z

Make the changes suggested by the linter. Has improved some things already

…evice and scalar type maps in torch-tensor.cpp

…as clang-tidy would have you believe

… can find them

codecov-commenter · 2024-07-27T22:27:03Z

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 86.36364% with 9 lines in your changes missing coverage. Please review.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files	Coverage Δ
nuTens/propagator/const-density-solver.hpp	`92.30% <100.00%> (ø)`
nuTens/propagator/propagator.hpp	`42.85% <ø> (ø)`
tests/barger.cpp	`77.77% <100.00%> (+1.30%)`	⬆️
tests/tensor-basic.cpp	`92.98% <100.00%> (ø)`
tests/test-utils.hpp	`0.00% <ø> (ø)`
tests/two-flavour-const-matter.cpp	`100.00% <100.00%> (ø)`
tests/two-flavour-vacuum.cpp	`100.00% <100.00%> (ø)`
nuTens/tensors/tensor.hpp	`87.50% <66.66%> (+1.78%)`	⬆️
tests/barger-propagator.hpp	`74.41% <94.11%> (-1.78%)`	⬇️
nuTens/propagator/propagator.cpp	`72.22% <60.00%> (+1.63%)`	⬆️
... and 1 more

ewanwm added 15 commits July 25, 2024 22:29

do what the linter says (has already fixed a potential bug with the d…

57a6e7a

…evice and scalar type maps in torch-tensor.cpp

Merge remote-tracking branch 'origin/main' into linting_start

b010d1b

more linting

fee16c1

yet more linting

73e7529

emplace_back doesn't seem to be as universally better than push_back …

60cf60f

…as clang-tidy would have you believe

I quite like using redundant access specifiers sometimes tbh

28c684e

MORE linting

358ce11

EVEN MORE LINTING

bdb90bb

Update cpp-linter.yaml to move around spdlog files so that clang-tidy…

f6f708e

… can find them

Update cpp-linter.yaml to ignore the spdlog files

39eafc6

try to fix clang errors

93c1b01

will the linting ever end?

eab9410

will this linter ever be satisfied?

2d9d90c

could this be.... it?

fa4fa42

Actually fail the linting check if there are suggestions

d294490

ewanwm merged commit dba66cc into main Jul 27, 2024
2 checks passed

ewanwm deleted the linting_start branch July 27, 2024 22:34