Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limiting account creation #138

Closed
multimeric opened this issue Oct 14, 2020 · 4 comments · Fixed by #141
Closed

Limiting account creation #138

multimeric opened this issue Oct 14, 2020 · 4 comments · Fixed by #141

Comments

@multimeric
Copy link
Collaborator

Currently I think it's possible to create an account and then start viewing data without requiring any authorisation. However it's reasonable that users might want new account creation to be subject to approval.

Considering this, I think the simplest solution would be to have a config setting (do we even have a config file?), or environment variable that enables "strict mode". Under this mode, the admin has to approve new accounts before they can actually log in, but the registration process is the same as usual.

Thoughts?

@multimeric
Copy link
Collaborator Author

Ah, it seems we have a MEGAQC_CONFIG environment variable that can point to a config file. Perfect!

@ewels
Copy link
Member

ewels commented Oct 14, 2020

Agreed, and I think that this should be on by default. At one point MegaQC had about two or three different config setups in parallel 🙈 There was one copying how MultiQC works, one from Flask etc. Maybe we got around to consolidating these though?

@ewels
Copy link
Member

ewels commented Oct 14, 2020

And maybe just call it user_registration_approval or something instead of strict mode? As I don't think that it's that strict 😅

@multimeric
Copy link
Collaborator Author

Sounds good to me!

@multimeric multimeric linked a pull request Oct 14, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants