Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QualiMap mean coverage #1082

Closed
BaiqiFu opened this issue Dec 16, 2019 · 8 comments
Closed

QualiMap mean coverage #1082

BaiqiFu opened this issue Dec 16, 2019 · 8 comments
Labels
bug: core Bug in the main MultiQC code priority: high

Comments

@BaiqiFu
Copy link

BaiqiFu commented Dec 16, 2019

Description of bug:
Qualimap: mean coverage computation for general statistics seems incorrect.

MultiQC Error log:
MultiQC Report:
image

QualiMap Report (CG_R):
image

File that triggers the error:
see example_data.zip

MultiQC run details (please complete the following):

  • Command used to run MultiQC: /data1/software/python/3.8.0/bin/multiqc --force --filename xx --outdir . bamqc/*_bamqc
  • MultiQC Version: [MultiQC v1.8]
  • Operating System: [CentOS 7]
  • Python Version: [Python 3.8.0]
  • Method of MultiQC installation: [pip]
@ewels ewels added bug: core Bug in the main MultiQC code priority: high labels Dec 16, 2019
@ewels
Copy link
Member

ewels commented Dec 16, 2019

Hmm, @apeltzer - any ideas what is going on here?

@apeltzer
Copy link
Contributor

Not really but I can check - code doesn't show this behaviour easily...

@apeltzer
Copy link
Contributor

Ok, just so to give an update on this one here. I double-checked using the https://github.com/ewels/MultiQC_TestData/tree/master/data/modules/qualimap testdata:

QualiMap Report:
Bildschirmfoto 2019-12-18 um 09 36 19

MultiQC Report:
Bildschirmfoto 2019-12-18 um 09 36 25

Other sample:
Bildschirmfoto 2019-12-18 um 09 36 46
Bildschirmfoto 2019-12-18 um 09 39 56

As QualiMap doesn't provide median values, I can't compare these directly to what it computes but the outputs don't look weird/off for me 👎

Maybe QualiMap produces slightly different output now and didn't in the past? Need to check that too...

@apeltzer apeltzer mentioned this issue Dec 18, 2019
3 tasks
@apeltzer
Copy link
Contributor

Please see #1085 for a proposed fix for this.

@BaiqiFu
Copy link
Author

BaiqiFu commented Jan 8, 2020

Hello!

Thank you very much for your reply!

But this bug seems to still exist in my other projects.

BamQC:
bamqc.zip

MultiQC:
multiqc.zip

Command:

/data1/software/python/3.8.0/bin/multiqc --force --filename wheat_multi-bamqc --outdir multiqc bamqc/*_bamqc

MultiQC Version:

  1. pip install --upgrade --force-reinstall git+https://github.com/ewels/MultiQC.git

  2. https://github.com/apeltzer/MultiQC/tree/fix-qualimap

The above two versions are not correct.

So how do I choose the version?

@ewels
Copy link
Member

ewels commented May 23, 2020

Hi @BaiqiFu,

The PR to fix this was only merged a few weeks ago - I'm not entirely sure which version you were running, but either way it seems fixed to me now. See an example report that I just generated with the latest version of the code using your bamqc.zip data: multiqc_report.html.zip

This should now work with the latest v1.9dev code (the install command 1 from your post above will install this now), and will be released properly soon.

Let me know if you're still having problems,

Phil

@ewels ewels closed this as completed May 23, 2020
@BaiqiFu
Copy link
Author

BaiqiFu commented Jun 5, 2020

Hi

Now I am using the v1.9,this version works very well without problems!
Thank you very much for your work!

@ewels
Copy link
Member

ewels commented Jun 5, 2020

Ok great! Thanks for letting us know :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: core Bug in the main MultiQC code priority: high
Projects
None yet
Development

No branches or pull requests

3 participants